[SPARK-51529] Support TLS connections
#82
Closed
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
TLS connections
|
While experimenting with the client, I found another issue: It will always create a new connection and not reuse an existing connection for the session. Every time where It would be great to make the connection stateful because otherwise it will be a lot of overhead of establishing connections and every time doing a TLS handshake. But this can easily be addressed in a follow up PR. |
grundprinzip
approved these changes
Apr 22, 2025
|
Thank you for verifying TLS feature, @grundprinzip . Yes, reusing and reconnection feature is related to many implementation details. So, I'm stilling working on it. Merged to main! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support TLS connections between
Spark Connect Client for SwiftandSpark Connect Server.Why are the changes needed?
For feature parity.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No.